Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml serializers for shortcircuit extensions (#389) (requires !436) #437

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

sebalaig
Copy link
Contributor

@sebalaig sebalaig commented May 11, 2022

⚠️ This PR depends on PR436 and target branch should be updated once PR436 has been merged (should be merged into integration/v1.6.0)

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
Closes #389
Also contains modifications introduced by powsybl/powsybl-core#1925

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@sebalaig sebalaig self-assigned this May 11, 2022
@sebalaig sebalaig changed the title Add xml serializers for shortcircuit extensions (#389) Add xml serializers for shortcircuit extensions (#389) (requires !436) May 11, 2022
@sebalaig sebalaig linked an issue May 11, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 2 Code Smells

56.4% 56.4% Coverage
0.0% 0.0% Duplication

@sebalaig sebalaig force-pushed the 384-add-shortcircuit-extensions branch from a69b496 to 5a62104 Compare May 24, 2022 09:02
Base automatically changed from 384-add-shortcircuit-extensions to integration/v1.6.0 July 12, 2022 16:05
@sebalaig sebalaig force-pushed the 389-add-shortcircuit-ext-xml-serializers branch from 4995996 to 96cae1d Compare July 13, 2022 08:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 2 Code Smells

56.4% 56.4% Coverage
0.0% 0.0% Duplication

@mathbagu mathbagu merged commit 1d1da56 into integration/v1.6.0 Jul 13, 2022
@mathbagu mathbagu deleted the 389-add-shortcircuit-ext-xml-serializers branch July 13, 2022 12:31
gautierbureau pushed a commit that referenced this pull request Nov 15, 2023
* Add GeneratorShortCircuitXmlSerializer
* Add IdentifiableShortCircuitXmlSerializer

Signed-off-by: Sébastien LAIGRE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shortcircuits extensions xml serializer
2 participants