Update traverse API (#362, #367, #394 and #387) #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 11, 2022
Closed
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
2 times, most recently
from
0dc053f to
4beebf4
Compare
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
from
71223a1 to
c46cddb
Compare
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
from
eb5d179 to
cc96bb2
Compare
sebalaig
changed the title
mathbagu
requested changes
Mar 28, 2022
| for (const Switch& sw : topo.getSwitches() | boost::adaptors::filtered(filterNotEncounteredSwitches)) { | ||
| topo.removeSwitch(sw.getId()); | ||
| } | ||
| } |
There was a problem hiding this comment.
It's not totally equivalent to Java implementation, is it not simpler if the encounteredSwitches is converted to a Set of ID. Then, the filter could be simplified and the whole method would be more maintainable.
mathbagu
added
PR: corrected
PR: waiting-for-review
and removed
PR: waiting-for-correction
labels
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
from
127e784 to
93426a3
Compare
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
from
93426a3 to
3243b4b
Compare
mathbagu
requested changes
May 23, 2022
There was a problem hiding this comment.
Could you please backport this PR (powsybl/powsybl-core#2044)? Don't forget to update the content of the issue related to this PR to mention the PR.
mathbagu
added
PR: waiting-for-correction
and removed
PR: corrected
PR: waiting-for-review
labels
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
2 times, most recently
from
32368a8 to
624c288
Compare
There is no such issue in C++, but I mentionned PR#2044 in this PR's description. |
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Sébastien LAIGRE <[email protected]>
This was
linked to
issues
May 24, 2022
sebalaig
force-pushed
the
issue362-stop-traversal-from-main
branch
from
624c288 to
5ba4804
Compare
mathbagu
approved these changes
May 24, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien LAIGRE [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restCloses #362
Closes #367
Closes #383 (updated in #387)
Closes #387
Closes #388
Closes #394
Also backport powsybl/powsybl-core#2044
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)