Fix sonar smells

Signed-off-by: Sébastien LAIGRE <[email protected]>
powsybl · Feb 28, 2022 · c46cddb · c46cddb
1 parent 180aa52
commit c46cddb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/include/powsybl/math/UndirectedGraph.hpp b/include/powsybl/math/UndirectedGraph.hpp
@@ -94,7 +94,7 @@ class UndirectedGraph {
 
     bool traverse(unsigned long v, const Traverser& traverser) const;
 
-    bool traverse(stdcxx::const_range<unsigned long>& startingVertices, const Traverser& traverser) const;
+    bool traverse(const stdcxx::const_range<unsigned long>& startingVertices, const Traverser& traverser) const;
 
     bool traverse(unsigned long v, const Traverser& traverser, std::vector<bool>& encountered) const;
 

diff --git a/include/powsybl/math/UndirectedGraph.hxx b/include/powsybl/math/UndirectedGraph.hxx
@@ -425,14 +425,12 @@ bool UndirectedGraph<V, E>::traverse(unsigned long v, const Traverser& traverser
 }
 
 template <typename V, typename E>
-bool UndirectedGraph<V, E>::traverse(stdcxx::const_range<unsigned long>& startingVertices, const Traverser& traverser) const {
+bool UndirectedGraph<V, E>::traverse(const stdcxx::const_range<unsigned long>& startingVertices, const Traverser& traverser) const {
     std::vector<bool> encountered(m_vertices.size(), false);
 
     for (unsigned long startingVertex : startingVertices) {
-        if (!encountered[startingVertex]) {
-            if (!traverse(startingVertex, traverser, encountered)) {
-                return false;
-            }
+        if (!encountered[startingVertex] && !traverse(startingVertex, traverser, encountered)) {
+            return false;
         }
     }
     return true;