Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc fix: add literal in mail addresses #76

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented May 14, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Same as powsybl/powsybl-core#2753

What kind of change does this PR introduce?
Javadoc update

What is the current behavior?
Mail addresses were written as @author Name Surname <author at email.address>

What is the new behavior (if this is a feature change)?
Mail addresses are written as @author Name Surname {@literal <author at email.address>}

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico requested review from EtienneLt and olperr1 May 14, 2024 08:00
@rolnico rolnico self-assigned this May 14, 2024
@rolnico rolnico changed the title replace email addresses Javadoc fix: add literal in mail addresses May 14, 2024
Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some are still missing, in:

  • ScontrolMonitor.java;
  • SlurmConstants.java.

You can see them using:

git grep author | grep -v "literal" | less

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rolnico rolnico merged commit a8e8636 into main May 14, 2024
6 checks passed
@rolnico rolnico deleted the nro/fix_email_addresses branch May 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants