Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning #72

Merged
merged 28 commits into from
May 14, 2024
Merged

Code cleaning #72

merged 28 commits into from
May 14, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Apr 25, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@rolnico rolnico self-assigned this Apr 25, 2024
rolnico added 11 commits April 29, 2024 10:14
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico changed the base branch from main to nro/code_coverage May 13, 2024 13:33
@rolnico rolnico force-pushed the nro/code_cleaning branch from fca9669 to 880a1a2 Compare May 13, 2024 13:35
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico requested review from EtienneLt and olperr1 May 13, 2024 13:48
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Base automatically changed from nro/code_coverage to main May 14, 2024 07:17
# Conflicts:
#	computation-slurm/src/test/java/com/powsybl/computation/slurm/ConcurrentSshCommandRunnerTest.java
#	computation-slurm/src/test/java/com/powsybl/computation/slurm/SlurmCmdNonZeroExceptionTest.java
#	computation-slurm/src/test/java/com/powsybl/computation/slurm/SlurmCmdTest.java
#	computation-slurm/src/test/java/com/powsybl/computation/slurm/SlurmComputationManagerTest.java
Copy link

@rolnico rolnico merged commit e53d2c1 into main May 14, 2024
6 checks passed
@rolnico rolnico deleted the nro/code_cleaning branch May 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants