-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update powsybl-core dependency #70
Conversation
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
computation-mpi/src/main/java/com/powsybl/computation/mpi/MpiJobSchedulerImpl.java
Outdated
Show resolved
Hide resolved
computation-slurm/src/main/java/com/powsybl/computation/slurm/AbstractTask.java
Show resolved
Hide resolved
computation-slurm/src/test/java/com/powsybl/computation/slurm/ScontrolCmdTest.java
Outdated
Show resolved
Hide resolved
computation-slurm/src/test/java/com/powsybl/computation/slurm/ScontrolCmdTest.java
Show resolved
Hide resolved
computation-slurm/src/main/java/com/powsybl/computation/slurm/SlurmStatusManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Warning : slurm integration tests must be done locally, using a server with SLURM installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an explanation for the disabled tests?
-@Disabled
+@Disabled("Slurm integration tests must be run locally.")
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to revert using powsybl-core 6.2.2 because of the CGMES import performance issue.
Signed-off-by: Nicolas Rol <[email protected]>
Done |
Signed-off-by: Nicolas Rol <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a problem with the test coverage, but appart that it seems ok to me.
Signed-off-by: Nicolas Rol <[email protected]>
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Dependencies upgrade
What is the current behavior?
HPC uses powsybl-core 4.1
What is the new behavior (if this is a feature change)?
powsybl-parent is bumped to v18
HPC uses powsybl-core 6.3.0
Java version is specified and switched to Java 17
junit version is specified (5.10.1)
Mockito is bumped to 5.10.0.
Does this PR introduce a breaking change or deprecate an API?
Other information: