Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update powsybl-core dependency #70

Merged
merged 24 commits into from
Apr 4, 2024
Merged

Update powsybl-core dependency #70

merged 24 commits into from
Apr 4, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Nov 14, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?
Dependencies upgrade

What is the current behavior?
HPC uses powsybl-core 4.1

What is the new behavior (if this is a feature change)?
powsybl-parent is bumped to v18
HPC uses powsybl-core 6.3.0
Java version is specified and switched to Java 17
junit version is specified (5.10.1)
Mockito is bumped to 5.10.0.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@rolnico rolnico requested a review from geofjamg November 14, 2023 12:03
@rolnico rolnico marked this pull request as draft November 14, 2023 12:03
@rolnico rolnico marked this pull request as ready for review November 15, 2023 16:22
@rolnico rolnico requested a review from olperr1 February 9, 2024 07:59
@rolnico rolnico changed the title bump powsybl-core to 5.3.2 Update powsybl-core dependency Feb 9, 2024
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico self-assigned this Feb 9, 2024
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
Copy link
Member Author

rolnico commented Feb 29, 2024

Warning : slurm integration tests must be done locally, using a server with SLURM installed

Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an explanation for the disabled tests?

-@Disabled
+@Disabled("Slurm integration tests must be run locally.")

Signed-off-by: Nicolas Rol <[email protected]>
Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to revert using powsybl-core 6.2.2 because of the CGMES import performance issue.

@rolnico
Copy link
Member Author

rolnico commented Mar 19, 2024

I think it would be best to revert using powsybl-core 6.2.2 because of the CGMES import performance issue.

Done

Signed-off-by: Nicolas Rol <[email protected]>
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a problem with the test coverage, but appart that it seems ok to me.

@olperr1 olperr1 merged commit 998e557 into main Apr 4, 2024
5 of 6 checks passed
@olperr1 olperr1 deleted the nro/bump_powsybl_core_5 branch April 4, 2024 15:35
@olperr1 olperr1 restored the nro/bump_powsybl_core_5 branch April 4, 2024 15:43
olperr1 pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants