[WIP]Move a ContingencyElement by using drag and drop in ContingencyStoreEditor #87
Conversation
gse-afs-ext-base/src/main/java/com/powsybl/gse/afs/ext/base/ContingencyStoreEditor.java
Outdated
Show resolved
Hide resolved
| return new BranchContingency(equipmentInfo.getIdAndName().getId()); | ||
|
|
||
| default: | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private EquipmentInfo createEquipmentInfo(ContingencyElement contingencyElement) { |
miovd
changed the title
miovd
force-pushed
the
move_contingencyelements
branch
2 times, most recently
from
5335313 to
75f2870
Compare
miovd
changed the title
| setOnDragDropped(this::onDragDropped); | ||
| } | ||
|
|
||
| private TreeItem<Object> checkTreeItem() { |
There was a problem hiding this comment.
Find a better name for this method. If I understand well, it get the TreeItem corresponding the selected element or null, if nothing is selected.
Proposal: getContingencyTreeItem()
This code is duplicate in addContingencyElement. Refactor addContingencyElement to use your method.
| private void onDragDropped(DragEvent event) { | ||
| if (event.getTransferMode().equals(TransferMode.MOVE) && | ||
| event.getGestureSource() instanceof ContingencyTreeCell) { | ||
| remove(); |
There was a problem hiding this comment.
If something goes wrong later, you can lost a Contingency item by removing it too early. I think you've to remove the item only if success = true, at the end of this method.
| private void onDragOver(DragEvent event) { | ||
| Dragboard db = event.getDragboard(); | ||
| if (!(event.getGestureSource() instanceof ContingencyTreeCell) || | ||
| checkTreeItem() != ((ContingencyTreeCell) event.getGestureSource()).checkTreeItem()) { |
There was a problem hiding this comment.
Firstly I think this code is quiet difficult to understand. In that case, feel free to put it in a dedicated method with an explicit name to hide complexity.
I think there is only one thing to check here, that can maybe be done in acceptSingleDraggedElement & acceptMultipleDraggedElements: test if the target node doesn't already contain one of the contingency element you're trying to drop.
miovd
changed the title
miovd
changed the title
miovd
changed the title
|
[WIP] Waiting for #124 to be approved |
miovd
changed the title
No description provided.