Issue 87 - Display standard networks in powsybl-dev-tools #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expected behavior can be realized as following example: |
flo-dup
force-pushed
the
87-display-standard-networks-in-powsybl-dev-tools
branch
from
0eda12c to
2887ce2
Compare
flo-dup
previously requested changes
Feb 5, 2024
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/MainViewController.java
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
tadam50
force-pushed
the
87-display-standard-networks-in-powsybl-dev-tools
branch
from
2887ce2 to
dda21b9
Compare
Signed-off-by: Thomas ADAM <[email protected]>
tadam50
force-pushed
the
87-display-standard-networks-in-powsybl-dev-tools
branch
from
71455a0 to
d89b49e
Compare
flo-dup
reviewed
Feb 7, 2024
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/MainViewController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <[email protected]>
flo-dup
reviewed
Feb 9, 2024
| @@ -152,6 +156,37 @@ public TreeItem<Container<?>> fromString(String string) { | |||
| sldViewController.addListener((observable, oldValue, newValue) -> updateSldDiagrams()); | |||
| } | |||
|
|
|||
| private void initializeNetworkFactories() { | |||
| Map<String, Supplier<Network>> suppliers = new HashMap<>(); | |||
| suppliers.put("BatteryNetwork", com.powsybl.iidm.network.test.BatteryNetworkFactory::create); | |||
There was a problem hiding this comment.
Could you add import com.powsybl.iidm.network.test.*; so that these lines are more compact?
flo-dup
reviewed
Feb 9, 2024
| @@ -14,6 +14,7 @@ | |||
| <Button fx:id="loadingStatus" minWidth="28" style="-fx-background-color: red"/> | |||
| <TextField fx:id="filePath" prefWidth="900" HBox.hgrow="ALWAYS" maxWidth="Infinity"/> | |||
| <Button onMouseClicked="#onClickLoadFile" text="..."/> | |||
| <MenuButton fx:id="networkFactoryMenuButton" text="Networks" minWidth="100"/> | |||
There was a problem hiding this comment.
And maybe just rename "Networks" into something like "Sample networks"?
Signed-off-by: Thomas ADAM <[email protected]>
|
So-Fras
approved these changes
Feb 13, 2024
So-Fras
deleted the
87-display-standard-networks-in-powsybl-dev-tools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
'Fixes #87'