Issue 86 VoltageLevelLayoutFactory customization #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadam50
changed the base branch from
main
to
issue_85_update_powsybl-dependencies
flo-dup
force-pushed
the
86-voltage-level-layout-factory-customization
branch
from
e6a53a1 to
9c8273e
Compare
flo-dup
requested changes
Feb 5, 2024
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/nad/NetworkAreaDiagramController.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/VoltageLevelLayoutFactoryBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/VoltageLevelLayoutFactoryBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/VoltageLevelLayoutFactoryBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/VoltageLevelLayoutFactoryBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/PositionVoltageLevelLayoutBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/PositionVoltageLevelLayoutBean.java
Outdated
Show resolved
Hide resolved
diagram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/SingleLineDiagramModel.java
Outdated
Show resolved
Hide resolved
...ram-viewer/src/main/java/com/powsybl/diagram/viewer/sld/SingleLineDiagramViewController.java
Outdated
Show resolved
Hide resolved
tadam50
force-pushed
the
86-voltage-level-layout-factory-customization
branch
from
9c8273e to
666db86
Compare
flo-dup
previously requested changes
Feb 9, 2024
| <ComboBox fx:id="voltageLevelLayoutComboBox"/> | ||
| <CheckBox fx:id="stackFeedersCheckBox" text="Stack feeders"/> | ||
| <EnumChoiceBox enumType="com.powsybl.diagram.viewer.sld.SingleLineDiagramModel$VoltageLevelLayoutFactoryType" fx:id="voltageLevelLayoutComboBox" initialValue="SMART"/> | ||
| <CheckBox fx:id="stackFeedersCheckBox" text="Stack feeders" selected="true"/> |
There was a problem hiding this comment.
there's also removeUnnecessaryFictitiousNodes and substituteSingularFictitiousByFeederNode which are supposed to be true by default
| @Override | ||
| public String toString() { | ||
| return switch (this) { | ||
| case SMART -> "Smart"; |
There was a problem hiding this comment.
Maybe "'Smart' choice", to highlight the choice behind? because the SmartSelector chooses position with extensions if the vl contains at least one position extension, if not it chooses cgmes diagram layout if there's at least one cgmes extension, if not it chooses clustering.
So-Fras
approved these changes
Feb 13, 2024
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
Signed-off-by: Thomas ADAM <[email protected]>
So-Fras
force-pushed
the
86-voltage-level-layout-factory-customization
branch
from
7c3e873 to
efaae20
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
'Fixes #86'
Other information:
Need issue #85 to be merged before this PR merge