Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade diagram viewer to powsybl 2023.3.0 #81

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Update dependencies.

What is the current behavior?

What is the new behavior (if this is a feature change)?
Minimal refactoring to adapt to the new API in PowSyBl diagrams.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@zamarrenolm zamarrenolm requested a review from So-Fras October 3, 2023 21:27
@So-Fras
Copy link
Member

So-Fras commented Oct 23, 2023

The current state of the code is not completly satisfactory.

I suggest to let it this way until next release of powsybl-diagram (V4.1.0). That release is going to correct a bug in the new single-line diagram API so that VoltageLevelLayoutFactory customization will be possible again.

That correction should be reflected in powsybl-dev-tools. The VoltageLevelLayoutFactoryCreator should be built inside a VoltageLevelLayoutFactoryCreatorBean:

  • From the value of the combo box (that should not be transformed into a VoltageLevelLayoutFactory or a VoltageLevelLayoutFactoryCreator right away but be provided as a String or an Enum to the VoltageLevelLayotuFactoryCreatorBean)

  • And potentially from other parameters too (if "Auto extensions" or "Auto without extensions Clustering" has been selected)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@So-Fras So-Fras merged commit 60516fd into main Nov 20, 2023
4 checks passed
@So-Fras So-Fras deleted the upgrade_to_powsybl_2023_3_0 branch November 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants