-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade diagram viewer to powsybl 2023.3.0 #81
Conversation
Signed-off-by: Luma <[email protected]>
Signed-off-by: Luma <[email protected]>
Signed-off-by: Luma <[email protected]>
Signed-off-by: Luma <[email protected]>
…elated code Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
The current state of the code is not completly satisfactory. I suggest to let it this way until next release of powsybl-diagram (V4.1.0). That release is going to correct a bug in the new single-line diagram API so that VoltageLevelLayoutFactory customization will be possible again. That correction should be reflected in powsybl-dev-tools. The VoltageLevelLayoutFactoryCreator should be built inside a VoltageLevelLayoutFactoryCreatorBean:
|
Kudos, SonarCloud Quality Gate passed! |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Update dependencies.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Minimal refactoring to adapt to the new API in PowSyBl diagrams.
Does this PR introduce a breaking change or deprecate an API?
Other information: