Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIDM ValidationLevel: Add the silent option. #3273

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Jan 14, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

When only an EQ file is imported after setting the validation level to EQUIPMENT, the validation process generates warnings indicating that some equipment attributes are not defined. These warnings are unnecessary, as we know that only the equipment attributes are imported.

What is the new behavior (if this is a feature change)?

In the validation process, a new option (SILENT) has been added. The validation level warnings are only generated when the runValidationChecks is executed. With this PR, it will be possible to import the EQ and SSH files separately without generating unnecessary warnings.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: marquesja1 <[email protected]>
@marqueslanauja marqueslanauja marked this pull request as ready for review January 21, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants