Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test files #3247

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove unused test files #3247

wants to merge 3 commits into from

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Dec 4, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Cleaning

What is the current behavior?
Many reference files are unused in powsybl-iidm-serde unit tests

What is the new behavior (if this is a feature change)?
The unused files are deleted.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <[email protected]>
Copy link

sonarqubecloud bot commented Dec 9, 2024

Comment on lines -46 to +45
ExportOptions options = new ExportOptions();
testWriteVersionedXml(network, options.setTopologyLevel(TopologyLevel.NODE_BREAKER), "fictitiousSwitchRef.xml", CURRENT_IIDM_VERSION);
testWriteXml(network, "/fictitiousSwitchRef.xml");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to have no tests on previous versions?

I think the problem here is essentially the fact that only the last version is checked.
Shouldn't we have something like this instead?

testForAllVersionsSince(IidmVersion.V_1_0, v -> {
    try {
        testWriteVersionedXml(network, options.setTopologyLevel(TopologyLevel.NODE_BREAKER), "fictitiousSwitchRef.xml", v);
    } catch (IOException e) {
        throw new RuntimeException(e);
    }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants