Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of filter in controlarea query #3222

Draft
wants to merge 3 commits into
base: remove_cgmes_control_areas_extension
Choose a base branch
from

Conversation

rcourtier
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Improve performance

What is the current behavior?

ControlArea SPARQL query is using a FILTER REGEX clause. This isn't optimal performance-wise.

What is the new behavior (if this is a feature change)?

The query has been slightly changed to use a VALUES clause instead, which gives better performances.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

@rcourtier rcourtier self-assigned this Nov 21, 2024
@rcourtier rcourtier marked this pull request as draft November 21, 2024 15:28
Signed-off-by: Romain Courtier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant