Cgmes import update. Import EQ and SSH separately. Transformers #3201

marqueslanauja · 2024-11-06T11:50:41Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

EQ and SSH are imported together during the conversion process.

What is the new behavior (if this is a feature change)?

EQ and SSH are imported separately.
The objective we will end up importing a single EQ and multiple SSH files.

All the changes will be split in multiple smaller PRs so the implementation will be done in an incremental way.
Current main workflow will be kept for some equipment. We will move them one by one to the new scheme.
This PR contains only the changes for transformers.

When performing the update, we traverse all the IIDM transformers and for each transformer we obtain the SSH data and call a specific update method that updates the status of the terminals, as well as some ratioTapChanger and phaseTapChanger attributes and the operationalLimits.

The update method is located in the corresponding convert class and we define a different update class for each
equipment. The update classes are defined as public static classes.

There are some methods with both implementations:

connect and convertedTerminals for importing EQ + SSH together
connectWithOnlyEq and convertedTerminalsWithOnlyEq for importing EQ + SSH separately

The validation scheme has been modified, initially the validation level is set to EQUIPMENT and only after the update is moved to SSH.

The normalTapPosition is now recorded in the CgmesTapChanger extension. In the current version, it was previously recorded only for hidden tapChangers.

TerminalSign is now recorded as a property when tapChangers are controlling active or reactive power.

The normalTapPosition is now used when two tapChangers must be combined. In the current version, the SSH or SV tapPosition is used.

Operational Limit Ids and their corresponding values are recorded as properties to be used in the update process.

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: marquesja1 <[email protected]>

Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java

Signed-off-by: marquesja1 <[email protected]>

Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/AbstractCgmesModel.java

Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/OperationalLimitConversion.java # cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/AbstractCgmesModel.java

Signed-off-by: marquesja1 <[email protected]>

Signed-off-by: Luma <[email protected]>

Signed-off-by: marquesja1 <[email protected]>

…date_network_transformers Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesImport.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Update.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/AbstractConductingEquipmentConversion.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/EnergyConsumerConversion.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/ConversionUtil.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/LoadUpdateTest.java # cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-invalid-voltage-bus.txt # cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-target-deadband.txt # cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE.txt # cgmes/cgmes-conversion/src/test/resources/functional-logs/miniGridNodeBreaker.txt

Signed-off-by: marquesja1 <[email protected]>

Signed-off-by: marquesja1 <[email protected]> (cherry picked from commit 5bb3d08)

Signed-off-by: marquesja1 <[email protected]>

…ts used in the update process Signed-off-by: marquesja1 <[email protected]>

sonarqubecloud · 2024-12-12T15:37:14Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

marqueslanauja added 30 commits October 16, 2024 08:08

update loads.

dcce636

Signed-off-by: marquesja1 <[email protected]>

Update loads

6bc53a8

Signed-off-by: marquesja1 <[email protected]>

Adjust validationUtil

0241870

Signed-off-by: marquesja1 <[email protected]>

Adjust FunctionalLogsTests

e1e04b2

Signed-off-by: marquesja1 <[email protected]>

Fix all the tests

3eafccf

Signed-off-by: marquesja1 <[email protected]>

Fix issues

3884a51

Signed-off-by: marquesja1 <[email protected]>

Pretty code

71bb0f0

Signed-off-by: marquesja1 <[email protected]>

Pretty code

fafaf11

Signed-off-by: marquesja1 <[email protected]>

Pretty code

004b824

Signed-off-by: marquesja1 <[email protected]>

update

8dc44cf

Signed-off-by: marquesja1 <[email protected]>

Typo

81954c6

Signed-off-by: marquesja1 <[email protected]>

Typo

2e6657b

Signed-off-by: marquesja1 <[email protected]>

Updating report

cbb0f54

Signed-off-by: marquesja1 <[email protected]>

update voltage and angles after the update

b3d0945

Signed-off-by: marquesja1 <[email protected]>

Fix code smells

7e3766a

Signed-off-by: marquesja1 <[email protected]>

Minor changes

df10d15

Signed-off-by: marquesja1 <[email protected]>

Pretty code

5114bde

Signed-off-by: marquesja1 <[email protected]>

Reduce complexity

69ade84

Signed-off-by: marquesja1 <[email protected]>

Reduce complexity

e4b95b3

Signed-off-by: marquesja1 <[email protected]>

Undo mistake made before

81376bd

Signed-off-by: marquesja1 <[email protected]>

pretty code

e7da075

Signed-off-by: marquesja1 <[email protected]>

Some improvements

4884abb

Signed-off-by: marquesja1 <[email protected]>

Some improvements

779d778

Signed-off-by: marquesja1 <[email protected]>

More improvements

cdc18f7

Signed-off-by: marquesja1 <[email protected]>

update by using static classes

5b2796c

Signed-off-by: marquesja1 <[email protected]>

Remove unused methods

324c805

Signed-off-by: marquesja1 <[email protected]>

update by using static classes

160edf1

Signed-off-by: marquesja1 <[email protected]>

Update comment

c9075ca

Signed-off-by: marquesja1 <[email protected]>

marqueslanauja added 2 commits November 14, 2024 16:15

Fix operational limits and pretty code

79e54ae

Signed-off-by: marquesja1 <[email protected]>

pretty code

42e4a14

Signed-off-by: marquesja1 <[email protected]>

rcourtier self-requested a review November 15, 2024 09:00

marqueslanauja and others added 11 commits December 11, 2024 08:18

Merge branch 'main' into cgmes_import_update_network_loads

3037fc2

Signed-off-by: marquesja1 <[email protected]> # Conflicts: # cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/AbstractCgmesModel.java

unitary tests

cfbcdde

Signed-off-by: marquesja1 <[email protected]>

Merge branch 'main' into cgmes_import_update_network_loads

5be3060

use proposed API for network updates

a23bad2

Signed-off-by: Luma <[email protected]>

Add unitary tests

52a6c8f

Signed-off-by: marquesja1 <[email protected]>

Pretty code

eee776c

Signed-off-by: marquesja1 <[email protected]>

Merge branch 'main' into cgmes_import_update_network_transformers

a0b8bfd

Minor changes.

3a5a3ae

Signed-off-by: marquesja1 <[email protected]>

Fix code smell

4485ba1

Signed-off-by: marquesja1 <[email protected]>

marqueslanauja changed the title ~~Cgmes import update network transformers~~ Cgmes import update. Import EQ and SSH separately. Transformers Dec 12, 2024

marqueslanauja added 3 commits December 12, 2024 12:38

Clean load queries

b63bbcd

Signed-off-by: marquesja1 <[email protected]> (cherry picked from commit 5bb3d08)

Clean transformer queries

c3a3893

Signed-off-by: marquesja1 <[email protected]>

Improve the management of properties associated with operational limi…

9409954

…ts used in the update process Signed-off-by: marquesja1 <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cgmes import update. Import EQ and SSH separately. Transformers #3201

Cgmes import update. Import EQ and SSH separately. Transformers #3201

marqueslanauja commented Nov 6, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 12, 2024

Cgmes import update. Import EQ and SSH separately. Transformers #3201

Are you sure you want to change the base?

Cgmes import update. Import EQ and SSH separately. Transformers #3201

Conversation

marqueslanauja commented Nov 6, 2024 • edited Loading

sonarqubecloud bot commented Dec 12, 2024

Quality Gate passed

marqueslanauja commented Nov 6, 2024 •

edited

Loading