Use DNS for S3 storage + set storage root directory in application.yml #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
etiennehomer
changed the title
jonenst
reviewed
Nov 22, 2024
| @@ -172,7 +173,7 @@ public String getOriginalFilename(UUID caseUuid) { | |||
| return getCaseMetaDataEntity(caseUuid).getOriginalFilename(); | |||
| } | |||
|
|
|||
| // key format is "gsi-cases/UUID/path/to/file" | |||
| // key format is "cases/UUID/path/to/file" | |||
There was a problem hiding this comment.
Suggested change
| // key format is "cases/UUID/path/to/file" | |
| // key format is "<rootDirectory>/UUID/path/to/file" |
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
jonenst
reviewed
Nov 22, 2024
| @@ -11,15 +11,15 @@ spring: | |||
| aws: | |||
| s3: | |||
| path-style-access-enabled: true | |||
| endpoint: http://172.17.0.1:19000 | |||
| endpoint: http://s3-storage:9000 | |||
There was a problem hiding this comment.
Suggested change
| endpoint: http://s3-storage:9000 | |
| # classic minio port, useful default for exploring | |
| endpoint: http://s3-storage:9000 |
jonenst
approved these changes
Nov 22, 2024
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
jonenst
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What is the current behavior?
We use the IP to connect to s3-storage.
What is the new behavior (if this is a feature change)?
We now use the DNS as we do for other technical containers.
Does this PR introduce a breaking change or deprecate an API?