Refactor Resource volume attach and documentation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkad
requested changes
Mar 25, 2024
| @@ -8,6 +8,7 @@ const ( | |||
| Arg_CloudInstanceID = "pi_cloud_instance_id" | |||
| Arg_ImageName = "pi_image_name" | |||
| Arg_InstanceName = "pi_instance_name" | |||
| Arg_InstanceId = "pi_instace_id" | |||
There was a problem hiding this comment.
Already have Arg_PVMInstanceId define
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| Arg_InstanceId: { |
| }, | ||
|
|
||
| // Computed Attribute | ||
| helpers.PIVolumeAttachStatus: { | ||
| Attr_VolumeAttachStatus: { |
There was a problem hiding this comment.
This should Attr_Status = status
| @@ -89,7 +88,7 @@ func resourceIBMPIVolumeAttachCreate(ctx context.Context, d *schema.ResourceData | |||
| log.Printf("Volume State /Status is permitted and hence attaching the volume to the instance") | |||
| } | |||
|
|
|||
| if volinfo.State == helpers.PIVolumeAllowableAttachStatus && !*volinfo.Shareable { | |||
| if volinfo.State == Attr_VolumeAllowableAttachStatus && !*volinfo.Shareable { | |||
There was a problem hiding this comment.
The value of PIVolumeAllowableAttachStatus = "in-use" need to be updated
|
|
||
| vol, err := client.CheckVolumeAttach(pvmInstanceID, volumeID) | ||
| if err != nil { | ||
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| d.Set(helpers.PIVolumeAttachStatus, vol.State) | ||
| d.Set(Attr_VolumeAttachStatus, vol.State) |
Comment on lines
+176
to
+177
| Pending: []string{"retry", Attr_VolumeProvisioning}, | ||
| Target: []string{Attr_VolumeAllowableAttachStatus}, |
There was a problem hiding this comment.
Need to update the const to be those
PIVolumeProvisioning = "creating"
PIVolumeAllowableAttachStatus = "in-use"
|
Opened #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: