Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VSN Resources, datasources, and attributes #173

Closed
wants to merge 1 commit into from
Closed

Adding VSN Resources, datasources, and attributes #173

wants to merge 1 commit into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Oct 17, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_virtual_serial_number (d):

=== RUN   TestAccIBMPIVirtualSerialNumber
--- PASS: TestAccIBMPIVirtualSerialNumber (29.53s)
PASS

pi_virtual_serial_numbers (d):

=== RUN   TestAccIBMPIVirtualSerialNumbers
--- PASS: TestAccIBMPIVirtualSerialNumbers (27.74s)
PASS

pi_virtual_serial_number (r)

=== RUN   TestAccIBMPIVirtualSerialNumberBasic
--- PASS: TestAccIBMPIVirtualSerialNumberBasic (44.18s)
PASS

=== RUN   TestAccIBMPIVirtualSerialNumberWithInstance
--- PASS: TestAccIBMPIVirtualSerialNumberWithInstance (310.44s)
PASS

pi_instance (d)

=== RUN   TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (44.95s)
PASS

pi_instances (d)

=== RUN   TestAccIBMPIInstancesDataSource_basic
--- PASS: TestAccIBMPIInstancesDataSource_basic (22.78s)
PASS

pi_instance (r)

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (998.46s)
PASS

=== RUN   TestAccIBMPIInstanceVirtualSerialNumber
--- PASS: TestAccIBMPIInstanceVirtualSerialNumber (413.08s)
PASS

michaelkad
michaelkad reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

ibm/service/power/data_source_ibm_pi_virtual_serial_number.go Outdated Show resolved Hide resolved
ibm/service/power/data_source_ibm_pi_virtual_serial_numbers.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
michaelkad
michaelkad requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing data_source_pi_instance.go and data_source_pi_instances.go

@Alexander-Kita
Copy link
Collaborator Author

@michaelkad Added to datasources

michaelkad
michaelkad requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review

website/docs/d/pi_instance.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_instance.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_instances.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_instances.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_virtual_serial_numbers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
michaelkad
michaelkad requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

website/docs/d/pi_virtual_serial_numbers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_virtual_serial_number.html.markdown Outdated Show resolved Hide resolved
@Alexander-Kita Alexander-Kita force-pushed the vsn-instances branch 3 times, most recently from a438936 to b1de83b Compare November 5, 2024 19:35
michaelkad
michaelkad previously approved these changes Nov 5, 2024
View reviewed changes
@Alexander-Kita Alexander-Kita marked this pull request as ready for review November 5, 2024 20:42
@Alexander-Kita
Copy link
Collaborator Author

@ismirlia Docs fixed in latest push

ismirlia
ismirlia previously approved these changes Nov 22, 2024
View reviewed changes
@Alexander-Kita Alexander-Kita force-pushed the vsn-instances branch 5 times, most recently from eea561d to ff58df5 Compare December 5, 2024 00:06
ismirlia
ismirlia reviewed Dec 5, 2024
View reviewed changes
website/docs/r/pi_virtual_serial_number.html.markdown Outdated
- `region` - `lon`
- `zone` - `lon04`

Example usage:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example usage:
Example usage:

michaelkad
michaelkad approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ismirlia
ismirlia approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo: IBM-Cloud#5854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia approved these changes

@michaelkad michaelkad michaelkad approved these changes

Assignees
No one assigned
Labels
Datasource Q4 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @michaelkad @ismirlia