Add check for same instance ID

powervs-ibm · Oct 30, 2024 · 8933960 · 8933960
1 parent f1afbf4
commit 8933960
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/ibm/service/power/resource_ibm_pi_virtual_serial_number.go b/ibm/service/power/resource_ibm_pi_virtual_serial_number.go
@@ -124,28 +124,30 @@ func resourceIBMPIVirtualSerialNumberCreate(ctx context.Context, d *schema.Resou
 			return diag.FromErr(err)
 		}
 
-		serialNumber := d.Get(Arg_Serial).(string)
-		addBody := &models.AddServerVirtualSerialNumber{
-			Serial: &serialNumber,
-		}
-		if v, ok := d.GetOk(Arg_Description); ok {
-			addBody.Description = v.(string)
-		}
-		err = client.PVMInstanceAttachVSN(pvmInstanceIdArg, addBody)
-		if err != nil {
-			return diag.FromErr(err)
-		}
-
-		_, err = isWaitForPIInstanceStopped(ctx, instanceClient, pvmInstanceIdArg, d.Timeout(schema.TimeoutCreate))
-		if err != nil {
-			return diag.FromErr(err)
-		}
+		if oldPvmInstanceId == "" {
+			serialNumber := d.Get(Arg_Serial).(string)
+			addBody := &models.AddServerVirtualSerialNumber{
+				Serial: &serialNumber,
+			}
+			if v, ok := d.GetOk(Arg_Description); ok {
+				addBody.Description = v.(string)
+			}
+			err = client.PVMInstanceAttachVSN(pvmInstanceIdArg, addBody)
+			if err != nil {
+				return diag.FromErr(err)
+			}
 
-		if restartInstance {
-			err = startLparAfterVSNChange(ctx, instanceClient, pvmInstanceIdArg, d.Timeout(schema.TimeoutCreate))
+			_, err = isWaitForPIInstanceStopped(ctx, instanceClient, pvmInstanceIdArg, d.Timeout(schema.TimeoutCreate))
 			if err != nil {
 				return diag.FromErr(err)
 			}
+
+			if restartInstance {
+				err = startLparAfterVSNChange(ctx, instanceClient, pvmInstanceIdArg, d.Timeout(schema.TimeoutCreate))
+				if err != nil {
+					return diag.FromErr(err)
+				}
+			}
 		}
 
 		if vsnArg == AutoAssign {