This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[Fix] Watched Queries Race Condition #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition which is possible when initialising multiple PowerSync instances simultaneously.
For example: Initialising PowerSync in a
React.useStatemethod will initialize two clients if React strict mode is enabled.If the web environment is in a fresh state, having no previous DB initialized, the DB opening will take a few seconds. This will create multiple DB connections instead of the shared worker using a single cached connection. Table change updates are triggered per connection and will thus fail if an update is executed on a different connection.
This PR caches the promise of initialising the DB connection instead of the resolved connection. This should ensure that multiple open requests will still use the same DB connection.
This PR also reverts the listener change from #21 as this race condition was the root cause of the issue.