Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database/socket): Rework socket database #362

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Conversation

gfieni
Copy link
Contributor

@gfieni gfieni commented Jun 27, 2024

This PR reworks the socket database with a more robust and non-async TCP server.
The received data are now expected to be newline-terminated, as done by the hwpc-sensor. (powerapi-ng/hwpc-sensor#60)

@gfieni gfieni added the enhancement New feature or request label Jun 27, 2024
@gfieni gfieni force-pushed the feat/rework-socketdb branch from 63b98d8 to ce2c777 Compare June 27, 2024 16:28
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 48.93617% with 48 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (6cbce02) to head (ce2c777).
Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   67.69%   67.91%   +0.21%     
==========================================
  Files          74       73       -1     
  Lines        3102     3051      -51     
==========================================
- Hits         2100     2072      -28     
+ Misses       1002      979      -23     
Files Coverage Δ
src/powerapi/puller/puller_actor.py 91.30% <ø> (-0.70%) ⬇️
src/powerapi/utils/__init__.py 100.00% <ø> (ø)
src/powerapi/report/hwpc_report.py 90.90% <75.00%> (-1.10%) ⬇️
src/powerapi/puller/handlers.py 33.76% <27.27%> (+5.72%) ⬆️
src/powerapi/database/socket_db.py 55.40% <54.41%> (+9.95%) ⬆️

@gfieni gfieni merged commit 7f60c01 into master Jun 27, 2024
9 checks passed
@gfieni gfieni deleted the feat/rework-socketdb branch June 27, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant