Change SQL formatter library #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also let the SQL be highlighted even if not formatted.
It is less prone to parsing errors, popular (~2M weekly downloads) and used in VS code.
rjuju
approved these changes
Nov 14, 2024
|
Apparently this is failing during container image build, see https://github.com/powa-team/powa-podman/actions/runs/11847215631/job/33016547131 |
|
Sorry about that. I'll fix that soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mention in #227 (comment), the
sql-formatterdoesn't correctly handles reserved keywords when they are used as alias for tables.After some searching I found an other library which seem to be more popular and doesn't fail when formatting such queries.