Fix search_path race by separating commands way #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strk
requested changes
Jun 6, 2022
There was a problem hiding this comment.
The effects of the change are STILL a "reconnection", so why dropping the comment ? I'd keep the comment to make sure it doesn't break in the future.
Also, you did not specify WHY the \c reconnection failed for you (did it fail for you?). Asking an already running process to reconnect would be faster than quitting the process and starting a new one...
|
@strk Thanks for the comments.
Okay, sure.
The reproducible step is a bit complex, but it is as follows.
Another solution is
volumes:
- postgis:/var/lib/postgresql/data
+ healthcheck:
+ test: "pg_isready && psql -c \"\\dx\" | grep postgis_tiger_geocoder"
+ interval: 10s
+ timeout: 2s
+ retries: 5
+ start_period: 10s
redmine:
:
depends_on:
- - postgis
+ postgis:
+ condition: service_healthy |
|
imho: there is a related upstream issue: docker-library/postgres#146 the current upstream best practice : the best way to test if the container is "ready" is to connect to it using its external IP address (it does not listen externally until the initialization process is fully complete). |
|
I'm not understanding how this "waiting for service" is at all related
to using `\c` in the SQL stream. The long explanation did not explain
why `\c` could not be used.
|
|
@ImreSamu
Okay, sure. |
|
@ImreSamu I close this PR with issue #296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296
@ImreSamu (CC: @strk)
I create this PR with the following steps, so could you check this ?
Note that my environment is macOS Monterey M1 (Apple Silicon) with zsh, so I couldn't execute
make testdue to No.3 error.make updateto apply above changes to all.make testwith setting environment variables, but encounter the following bash error./usr/local/bin/docker-entrypoint.sh: sourcing /docker-entrypoint-initdb.d/10_postgis.sh CREATE DATABASE Loading PostGIS extensions into template_postgis CREATE EXTENSION CREATE EXTENSION CREATE EXTENSION CREATE EXTENSION Loading PostGIS extensions into postgres CREATE EXTENSION CREATE EXTENSION CREATE EXTENSION CREATE EXTENSION waiting for server to shut down....2022-06-06 09:33:26.107 UTC [48] LOG: received fast shutdown request