Add SHINYLIVE_WASM_PACKAGES environment variable
#116
Conversation
georgestagg
force-pushed
the
wasm-packages-envvar
branch
from
0fe70aa
to
123e9a6
Compare
R/quarto_ext.R
Outdated
| wasm_packages_val <- sys_env_wasm_packages() | ||
| wasm_packages <- as.logical(wasm_packages_val) | ||
| if (is.na(wasm_packages)) { | ||
| cli::cli_abort(c( | ||
| "x" = "Could not parse `wasm_packages` value: {.code {wasm_packages_val}}" | ||
| )) | ||
| wasm_packages <- SHINYLIVE_WASM_PACKAGES | ||
| } |
There was a problem hiding this comment.
I think it's worth putting this in a helper function
There was a problem hiding this comment.
Thanks, I realised we're only really expecting to see an NA when we're parsing the string from Sys.getenv(), so I've moved the check and cli_abort() into the sys_env_wasm_packages() function, avoiding the duplication.
Sounds good, I'll add an issue along those lines once this has been merged. |
|
I've also added a line in NEWS.md. Will also directly add a NEWS entry for #114 once this is merged. |
georgestagg
force-pushed
the
wasm-packages-envvar
branch
from
ed4bb73
to
48ee638
Compare
| #' @param wasm_packages Download and include binary WebAssembly packages as part | ||
| #' of the output app's static assets. Logical, defaults to `TRUE`. The default | ||
| #' value can be changed by setting the environment variable | ||
| #' `SHINYLIVE_WASM_PACKAGES` to `TRUE` or `1` to enable, `FALSE` or `0` to |
There was a problem hiding this comment.
It's annoying, but I think we should allow literally "true" or "false", or the whole range of TRUE, "TRUE", "true", "1" and 1 and false variants. (Basically, `tolower(val) %in% c("true", "1").)
I would read this expecting I could set SHINYLIVE_WASM_PACKAGES=TRUE in .Renviron, but IIRC that will end up being "TRUE" when set.
There was a problem hiding this comment.
I think this should be handled OK by:
pkgs_env <- switch(pkgs_env, "1" = TRUE, "0" = FALSE, pkgs_env)
wasm_packages <- as.logical(pkgs_env)Because "1" will be caught by the switch, and then "TRUE"/"true" will be caught by the as.logical().
> as.logical("TRUE")
[1] TRUE
> as.logical("true")
[1] TRUE
> as.logical(TRUE)
[1] TRUE
> as.logical("false")
[1] FALSE
> as.logical("something-weird")
[1] NASaying that, I might change it just to make things clearer.
There was a problem hiding this comment.
oh nice, that makes sense. I just missed that as.logical() line
Continuing the work in #114 and earlier PRs, adds an environment variable
SHINYLIVE_WASM_PACKAGES, defaulting toTRUE.When
SHINYLIVE_WASM_PACKAGESis set toFALSEor0, no wasm R packages are exported at all. This allows the user to turn off the mechanism when using Shinylive with Quarto, should they want to.Closes quarto-ext/shinylive#60.