Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid LinkingTo dependencies in package resolution #115

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Avoid LinkingTo dependencies in package resolution #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546d3fc
Avoid LinkingTo dependencies in package resolution
georgestagg Aug 2, 2024
cb37e79
Update NEWS.md
georgestagg Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# shinylive (development version)

* shinylive now avoids bundling WebAssembly R package dependencies listed only in the `LinkingTo` section of required packages. With this change dependencies that are only required at build time are no longer included as part of the exported WebAssembly asset bundle. This reduces the total static asset size and improves the loading time of affected shinylive apps. (#115)

# shinylive 0.2.0

* shinylive now uses [shinylive web assets v0.5.0](https://github.com/posit-dev/shinylive/releases/tag/v0.5.0) by default, which bundles webR 0.4.0 with R 4.4.1. This update brings improved keyboard shortcuts for R users in the Shinylive editor, the ability to export a custom library of R packages with the exported app, and a few improvements to the Quarto integration. (#108)
Expand Down
5 changes: 3 additions & 2 deletions R/packages.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,16 @@ sys_env_max_filesize <- function() {
if (max_fs_env == "") NULL else max_fs_env
}

# Resolve package list hard dependencies
# Resolve package list, dependencies listed in Depends and Imports
resolve_dependencies <- function(pkgs, local = TRUE) {
pkg_refs <- if (local) {
refs <- find.package(pkgs, lib.loc = NULL, quiet = FALSE, !is_quiet())
glue::glue("local::{refs}")
} else {
pkgs
}
inst <- pkgdepends::new_pkg_deps(pkg_refs)
wasm_config <- list(dependencies = c("Depends", "Imports"))
inst <- pkgdepends::new_pkg_deps(pkg_refs, config = wasm_config)
inst$resolve()
unique(inst$get_resolution()$package)
}
Expand Down