Add configurable session timeouts for supervisor #5693
Merged
+248
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
approved these changes
Dec 10, 2024
|
Yeah, we'll eventually want to put this in the workbench docs so admins can bump the timeout (or instruct users to do so if they're hitting a wall). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5620 by adding an option to specify the number of seconds to wait for the kernel to connect before giving up. This change is mostly on the supervisor side; the client changes here just add the new option and pass it along to the supervisor.
The default was 20 (hardcoded) and is now 30 (configurable).
While I was updating the API, I also added some methods/types that will later support #5226 (but aren't currently implemented on the client or server side).
QA Notes
A really easy way to test this is to set the timeout at 1 second, since most kernels do not start up that quickly.