Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ability to run additional test tags against PRs #5658

Merged
merged 75 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
0bbc687
inputs
midleman Dec 7, 2024
42269a8
dispatch wflows
midleman Dec 8, 2024
67b4b4b
test nightly
midleman Dec 8, 2024
d90861d
bool
midleman Dec 8, 2024
baadc61
this instead
midleman Dec 8, 2024
ca86dd2
or null
midleman Dec 8, 2024
aaf87cd
try name
midleman Dec 8, 2024
55842e8
display_name
midleman Dec 8, 2024
355f638
fix grep
midleman Dec 9, 2024
e177a04
fix browser and windows
midleman Dec 9, 2024
9323316
e2e-windows
midleman Dec 9, 2024
e229cb2
extracted_tags
midleman Dec 9, 2024
1c532eb
update greps
midleman Dec 9, 2024
79b3e7f
experiment
midleman Dec 9, 2024
e3d1fcf
add license
midleman Dec 9, 2024
99976ca
tags script
midleman Dec 9, 2024
d59d365
update script
midleman Dec 9, 2024
ecd5aa7
try test again
midleman Dec 9, 2024
60900f5
test windows
midleman Dec 9, 2024
6f1c83b
fix pr push wflow
midleman Dec 9, 2024
8f84ae4
Merge branch 'main' into mi/update-e2e-workflow
midleman Dec 9, 2024
64e14a0
rename test to e2e
midleman Dec 9, 2024
17783e4
cleanup
midleman Dec 9, 2024
a4d0ede
fix windows
midleman Dec 9, 2024
a10da41
random suffix, unit, intg
midleman Dec 9, 2024
236d0d1
add unit/integ
midleman Dec 9, 2024
a28dfef
rename workflows
midleman Dec 9, 2024
c277874
tab the problem?
midleman Dec 9, 2024
e9bd917
fix windows
midleman Dec 9, 2024
21b0864
remove e2e-report
midleman Dec 9, 2024
8e27f03
fix typo
midleman Dec 9, 2024
92a03f1
split merge/pr wflow
midleman Dec 9, 2024
4badf23
try this
midleman Dec 9, 2024
b456da5
fix conditions
midleman Dec 9, 2024
5edb67e
replace
midleman Dec 9, 2024
748fb84
mv and update tags
midleman Dec 9, 2024
e17921e
move
midleman Dec 9, 2024
57474d3
cleanup
midleman Dec 9, 2024
33de830
update tags
midleman Dec 9, 2024
63623ad
empty string
midleman Dec 9, 2024
8f4fa0a
oops
midleman Dec 9, 2024
bcc862f
parse body
midleman Dec 10, 2024
23525be
Merge branch 'main' into mi/update-e2e-workflow
midleman Dec 10, 2024
19a9d39
&
midleman Dec 10, 2024
f75cf15
fix project
midleman Dec 10, 2024
115a762
fix output
midleman Dec 10, 2024
9aae7c6
fix output
midleman Dec 10, 2024
41916b1
@critical and remove dupes
midleman Dec 10, 2024
c2bd645
update defaults
midleman Dec 10, 2024
343d390
use gh env
midleman Dec 10, 2024
253edf8
fix output
midleman Dec 10, 2024
40ad315
update script
midleman Dec 10, 2024
293b9c2
add parse-pr-tags.sh
midleman Dec 10, 2024
a9bd3a4
Merge branch 'main' into mi/update-e2e-workflow
midleman Dec 10, 2024
a1e3f56
add checkout
midleman Dec 10, 2024
eb952fa
remove body
midleman Dec 10, 2024
b8c9f7f
update template
midleman Dec 10, 2024
26fab37
test full
midleman Dec 10, 2024
b956791
disable pr for now
midleman Dec 10, 2024
fb20ef3
update description
midleman Dec 10, 2024
6709096
more descript updates
midleman Dec 10, 2024
711ed07
test release
midleman Dec 10, 2024
3b98832
test windows
midleman Dec 10, 2024
7e13e8c
test linux
midleman Dec 10, 2024
83d72e5
cleanup
midleman Dec 10, 2024
d4e214a
more cleanup
midleman Dec 10, 2024
c454024
fixes for currents_tags
midleman Dec 10, 2024
e0a12bb
fix slack hooks
midleman Dec 10, 2024
8b5e52e
rename script
midleman Dec 10, 2024
10df343
move pw tags
midleman Dec 10, 2024
d6e93f9
Merge branch 'main' into mi/update-e2e-workflow
midleman Dec 11, 2024
b4945c3
change parse regex
midleman Dec 11, 2024
a4b57b1
fix regex
midleman Dec 11, 2024
be0416c
rename scripts
midleman Dec 11, 2024
1facd54
update comments
midleman Dec 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions .github/actions/e2e-report/action.yml

This file was deleted.

27 changes: 27 additions & 0 deletions .github/actions/gen-report-dir/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: "Generate Report Directory & Send to GH Summary"
description: "Generates a unique REPORT_DIR and appends the report URL to the GitHub Step summary"
inputs:
bucket-url:
description: "Base URL of the S3 bucket or CDN for the report"
required: false
default: "https://d38p2avprg8il3.cloudfront.net"
runs:
using: "composite"
steps:
- name: Generate REPORT_DIR
shell: bash
run: |
# Generate a unique REPORT_DIR
RANDOM_SUFFIX=$RANDOM
REPORT_DIR="playwright-report-${{ github.run_id }}-${RANDOM_SUFFIX}"

# Export REPORT_DIR for downstream steps
echo "REPORT_DIR=$REPORT_DIR" >> $GITHUB_ENV
echo "Generated REPORT_DIR: $REPORT_DIR"

# Generate the REPORT_URL
REPORT_URL="${{ inputs.bucket-url }}/$REPORT_DIR/index.html"
echo "Report URL: $REPORT_URL"

# Append REPORT_URL to the GitHub Step summary
echo "📄 [Playwright Report]($REPORT_URL) <br>" >> $GITHUB_STEP_SUMMARY
5 changes: 4 additions & 1 deletion .github/actions/upload-report-to-s3/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ inputs:
role-to-assume:
description: "The AWS role to assume"
required: true
report-dir:
description: "The path to the directory containing the Playwright report"
required: true

runs:
using: "composite"
Expand All @@ -19,4 +22,4 @@ runs:
if: ${{ !cancelled() }}
shell: bash
run: |
aws s3 cp playwright-report/. s3://positron-test-reports/playwright-report-${{ github.run_id }} --recursive
aws s3 cp playwright-report/. s3://positron-test-reports/${{ inputs.report-dir }} --recursive
10 changes: 7 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ main branch by either pulling or rebasing.
<!--
Describe briefly what problem this pull request resolves, or what
new feature it introduces. Include screenshots of any new or altered
UI. Link to any GitHub issues but avoid "magic" keywords that will
automatically close the issue. If there are any details about your
approach that are unintuitive or you want to draw attention to, please
UI. Link to any GitHub issues but avoid "magic" keywords that will
automatically close the issue. If there are any details about your
approach that are unintuitive or you want to draw attention to, please
describe them here.
-->

### Tests to Run
<!-- See `test/e2e/helpers/test-tags.ts` for a complete list of available tags. -->
`@:critical`

### QA Notes

<!--
Expand Down
Loading
Loading