Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prerelease branches to the PR CI workflow (#5352) #5401

Merged

Conversation

sharon-wang
Copy link
Member

Backport #5352 to the prerelease/2024.09 branch.

Following
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-including-branches,
we can add the prerelease branch pattern `prerelease/**` so that the
usual PR CI is triggered when PRs are opened against prerelease
branches.

This is helpful for verifying backported fixes or fixes targeted for
prerelease branches.

I noticed this when I targeted my fix for #5197 for the prerelease
branch, merged it, but then ran into CI failures in my PR to bring in
the same fix to main. For the patch branch PR, I manually ran the Full
and Windows test suites, but missed the Python one.

### QA Notes

PRs against `prerelease` branches should now automatically kick off the
usual CI workflows that we see for PRs against `main`.
@sharon-wang sharon-wang changed the base branch from main to prerelease/2024.09 November 18, 2024 15:44
@sharon-wang
Copy link
Member Author

PR CI workflow is running on this branch!
image

@sharon-wang sharon-wang merged commit 32fdbf0 into prerelease/2024.09 Nov 18, 2024
4 checks passed
@sharon-wang sharon-wang deleted the backport/prerelease-2024.09-pr-ci-workflow branch November 18, 2024 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant