-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: brand_yaml
Python package
#12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result is that you can post-hoc re-use `with` values.
This will make it possible to blend color.{named} and color.with, plus other more complicated scenarios, without having to rewrite the recursive definition resolution for those scenarios individually.
cpsievert
reviewed
Oct 3, 2024
cpsievert
reviewed
Oct 3, 2024
cpsievert
reviewed
Oct 3, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
cpsievert
reviewed
Oct 4, 2024
* Fixes import and validation of font-weight ranges, e.g. "400..800" * Fixes writing of font-family CSS * Adds tests to assert expected behavior
Thanks for the reviews @cpsievert! I'm going to merge this but feel free to ping me here or offline if you have any more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo