Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semi colons on single line in statement range detection #638

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

# 0.1.9000

## 2024-11

- LSP: The statement range provider now has better support for expressions separated by `;` on a single line (posit-dev/positron#4317).


## 2024-10

- Objects assigned at top level are now indexed, in addition to assigned functions. When a name is assigned multiple times, we now only index the first occurrence. This allows you to jump to the first "declaration" of the variable. In the future we'll improve this mechanism so that you can jump to the most recent assignment.
Expand Down
2 changes: 1 addition & 1 deletion crates/ark/src/lsp/encoding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ fn convert_character_from_utf16_to_utf8(x: &str, character: usize) -> usize {
}

/// Converts a character offset into a particular line from UTF-8 to UTF-16
fn convert_character_from_utf8_to_utf16(x: &str, character: usize) -> usize {
pub(crate) fn convert_character_from_utf8_to_utf16(x: &str, character: usize) -> usize {
if x.is_ascii() {
// Fast pass
return character;
Expand Down
Loading
Loading