Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor statement range tests #636

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Refactor statement range tests #636

merged 1 commit into from
Nov 27, 2024

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Nov 25, 2024

  • Nest in top-level test module. Enables IDE gesture for running all tests in module.
  • Split tests in multiple functions so they can be run and debugged individually.

Partially done with AI (more struggle than expected).

@lionel- lionel- mentioned this pull request Nov 25, 2024
Open
DavisVaughan
DavisVaughan approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look too closely but seems nice. More easily debuggable is definitely a good thing

@lionel- lionel- merged commit 5c3e188 into main Nov 27, 2024
6 checks passed
@lionel- lionel- deleted the task/refactor-statement-range-tests branch November 27, 2024 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel- @DavisVaughan