Add support for haven_labelled in the data explorer
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also address posit-dev/positron#5010? |
|
No, I think for the variables pane, we'll probably want to implement a custom |
lionel-
approved these changes
Nov 27, 2024
| #[test] | ||
| fn test_frequency_table_haven_labelled() { | ||
| r_task(|| { | ||
| if !package_is_installed("haven") { |
There was a problem hiding this comment.
Also need to add haven to CI:
ark/.github/workflows/test-linux.yml
Line 54 in 5c3e188
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#5327 by specializing some data explorer code paths in order to support the haven labelled data type.
At some point we might also want to implement an extension mechanism here too, allowing packages to implement a method that would create a proxy object - that's then used to compute the summary stats, histograms/freq tables, etc.