Honor MAX_DISPLAY_ENTRIES when inspecting variables
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
Merged
lionel-
approved these changes
Nov 19, 2024
| for char in elt.chars() { | ||
| if display_value.len() >= MAX_DISPLAY_VALUE_LENGTH { | ||
| is_truncated = true; | ||
| break 'outer; |
There was a problem hiding this comment.
Neat syntax for long breaks
| let mut out: Vec<Variable> = vec![]; | ||
| let n = unsafe { Rf_xlength(value) }; | ||
|
|
||
| let list = List::new(value)?; |
| // We need to be careful when truncating the string, we don't want to return invalid | ||
| // UTF8 sequences. `chars` makes sure we are not splitting a UTF8 character in half. | ||
| // See also https://doc.rust-lang.org/book/ch08-02-strings.html#slicing-strings | ||
| fn truncate_chars(value: String, len: usize) -> (bool, String) { |
There was a problem hiding this comment.
IIUC String::truncate()would be unsafe here because it takes a byte offset, not a number of chars? I see in the docs:
Panics if new_len does not lie on a char boundary.
Tricky!
There was a problem hiding this comment.
Exactly! We either need to find the char index to truncate using the char_indices() iterator or make a copy like we do here.
crates/ark/src/variables/variable.rs
Outdated
| @@ -1779,6 +1818,14 @@ mod tests { | |||
| }) | |||
| } | |||
|
|
|||
| fn inspect_from_expr(code: &str) -> Vec<Variable> { | |||
| let env = harp::parse_eval_global("new.env()").unwrap(); | |||
There was a problem hiding this comment.
Probably worth adding an Environment method at some point.
There was a problem hiding this comment.
Added in 840a877, let me know what you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some performance related issues that involve the variables pane.
Addressing:
The goal is to have the following scenarios working fine in positron:
Note: When testing it's important to use a Release version of ark. In my tests, with debug can be 20x slower in such cases - probably for the tail recursion optimizations important for the object size computation.
Not fixed in this PR:
modelfrom Positron lags when running a model on big data positron#4636 takes about 1s. I think a lot of this time is computing the objects size - because of the deeply nested object.