Neon frontend #4624
Merged
Neon frontend #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 7, 2024 17:26
ianedwards
approved these changes
May 8, 2024
Comment on lines
+47
to
+56
| <Modal closeModal={onClose} width={"800px"}> | ||
| <Text size={16}>Integrate Neon</Text> | ||
| <Spacer y={0.5} /> | ||
| <Text color="helper"> | ||
| To continue, you must authenticate with Neon.{" "} | ||
| <Link target="_blank" onClick={openAuthWindow} hasunderline> | ||
| Authorize Porter to create Neon datastores on your behalf | ||
| </Link> | ||
| </Text> | ||
| </Modal> |
There was a problem hiding this comment.
is it worth showing this modal in a blocked / loading state after they go through the flow with neon, so they don't end up proceeding before we save the integration on our end?
There was a problem hiding this comment.
they cant proceed; if they click create again, they'll just see the same modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user can auth with neon, create neon datastore, see credentials and delete it