Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix porter cloud ingest aliases #4580

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Fix porter cloud ingest aliases #4580

merged 6 commits into from
Apr 25, 2024

Conversation

MauAraujo
Copy link
Contributor

@MauAraujo MauAraujo commented Apr 25, 2024 •
edited
Loading

POR-

What does this PR do?

This PR fixes some edge cases I found while validating the billing code:

  • Fixe an edge case with porter cloud ingest aliases collisioning with porter standard ingest aliases. This is rare but as Porter Cloud users start to grow the probability of collision will become higher, so I introduced a prefix for porter cloud aliases.
  • Fix an edge case where if the Metronme creation fails, the project billing id is not updated
  • Fix a small typo on the global banner showing remaining trial time
  • Improve some of the conditions and feature flag checks for billing

@MauAraujo MauAraujo changed the title Fix customer creation and porter cloud ingest aliases Fix porter cloud ingest aliases Apr 25, 2024
@MauAraujo MauAraujo enabled auto-merge (squash) April 25, 2024 18:06
@MauAraujo MauAraujo merged commit e0790e5 into master Apr 25, 2024
9 checks passed
@MauAraujo MauAraujo deleted the fix-customer-creation branch April 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianedwards ianedwards ianedwards approved these changes

@ferozemohideen ferozemohideen ferozemohideen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauAraujo @ferozemohideen @ianedwards