refactoring main, adding separate authn/z providers #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozemohideen
approved these changes
Apr 11, 2024
ianedwards
approved these changes
Apr 11, 2024
Comment on lines
30
to
48
| const authenticate = (): void => { | ||
| api | ||
| .checkAuth("", {}, {}) | ||
| .then((res) => { |
There was a problem hiding this comment.
can we refactor these to return promises? just for consistency and so that we're not unexpectedly assuming an async task has finished
dashboard/src/main/Main.tsx
Outdated
Comment on lines
32
to
39
| const { | ||
| authenticate, | ||
| handleLogOut, | ||
| isLoggedIn, | ||
| isLoading, | ||
| hasInfo, | ||
| isEmailVerified, | ||
| } = useContext(AuthnContext); |
There was a problem hiding this comment.
one suggestion that goes along with my other comment - wrap main in AuthnContext, wait for authenticate to complete, if not authenticated then return something other than main (redirect, un-authed page, etc).
This comes with the benefit that we don't need a flag like hasInfo and can instead assume the user is logged in from any child component defined in the router of Main
There was a problem hiding this comment.
we can then also have a user object provided by this context that is guaranteed to be defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.