inject env var for deprecated builder #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianedwards
approved these changes
Mar 18, 2024
edmorley
reviewed
Mar 20, 2024
| if opts.Env == nil { | ||
| opts.Env = map[string]string{} | ||
| } | ||
| opts.Env["ALLOW_EOL_SHIMMED_BUILDER"] = "1" |
There was a problem hiding this comment.
I would not recommend injecting this by default. Users may miss the EOL warning and not realise they need to upgrade ASAP.
As mentioned in heroku/cnb-builder-images#474 these images were superseded way back in June 2022, and we've been showing deprecation warnings in the build logs for 6 months now (we even attempted outreach about this in #3896).
There was a problem hiding this comment.
(These images will soon receive zero security updates, and at some further point after that may even be deleted)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POR-
What does this PR do?