fix service validation error (#4335)

porter-dev · Feb 27, 2024 · 0f5f5a3 · 0f5f5a3
1 parent 4a7c824
commit 0f5f5a3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/dashboard/src/main/home/app-dashboard/create-app/CreateApp.tsx b/dashboard/src/main/home/app-dashboard/create-app/CreateApp.tsx
@@ -409,6 +409,8 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
     // TODO: create a more unified way of parsing form/apply errors, unified with the logic in AppDataContainer
     const errorKeys = Object.keys(errors);
     if (errorKeys.length > 0) {
+      const stringifiedJson = JSON.stringify(errors);
+
       let errorMessage = "App could not be deployed as defined.";
       if (errorKeys.includes("app")) {
         const appErrors = Object.keys(errors.app ?? {});
@@ -431,7 +433,7 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
 
       void updateAppStep({
         step: "stack-launch-failure",
-        errorMessage: `Form validation error: ${errorMessage}`,
+        errorMessage: `Form validation error (visible to user): ${errorMessage}. Stringified JSON errors (invisible to user): ${stringifiedJson}`,
         appName: name.value,
       });
 

diff --git a/dashboard/src/shared/ClusterResourcesContext.tsx b/dashboard/src/shared/ClusterResourcesContext.tsx
@@ -41,7 +41,7 @@ const ClusterResourcesProvider = ({
 }): JSX.Element => {
   const { currentCluster, currentProject } = useContext(Context);
 
-  var {
+  const {
     maxCPU,
     maxRAM,
     defaultCPU,
@@ -56,21 +56,14 @@ const ClusterResourcesProvider = ({
     clusterStatus: currentCluster?.status,
   });
 
-  if (currentProject?.sandbox_enabled) {
-    defaultCPU = 0.1
-    defaultRAM = 120
-    maxRAM = 250
-    maxCPU = 0.2
-  }
-
   return (
     <ClusterResourcesContext.Provider
       value={{
         currentClusterResources: {
-          maxCPU,
-          maxRAM,
-          defaultCPU,
-          defaultRAM,
+          maxCPU: currentProject?.sandbox_enabled ? 0.2 : maxCPU,
+          maxRAM: currentProject?.sandbox_enabled ? 250 : maxRAM,
+          defaultCPU: currentProject?.sandbox_enabled ? 0.1 : defaultCPU,
+          defaultRAM: currentProject?.sandbox_enabled ? 120 : defaultRAM,
           maxGPU,
           clusterContainsGPUNodes,
           clusterIngressIp,