add support for infisical env groups #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-g-town
reviewed
Apr 19, 2024
porter/v1/env_group.proto
Outdated
Comment on lines
20
to
27
| enum EnumExternalEnvGroupProviderType { | ||
| // ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_UNSPECIFIED represents the nil value | ||
| ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_UNSPECIFIED = 0; | ||
| // ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_EXTERNAL_SECRETS represents the external-secrets env group provider | ||
| ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_EXTERNAL_SECRETS = 1; | ||
| // ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_INFISICAL represents the Infisical env group provider | ||
| ENUM_EXTERNAL_ENV_GROUP_PROVIDER_TYPE_INFISICAL = 2; | ||
| } |
There was a problem hiding this comment.
maybe we call this the EnvGroupDriver or EnvGroupOperator or EnvGroupIntegrator? Just to distinguish more from the ProviderType (external-secrets operator does not provide, it just helps us integrate with most providers)
There was a problem hiding this comment.
yeah fair, EnvGroupOperator makes sense to me
d-g-town
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.