coments

porter-dev · Apr 9, 2024 · 0a425c6 · 0a425c6
1 parent 896eac1
commit 0a425c6
Show file tree

Hide file tree

Showing 8 changed files with 793 additions and 746 deletions.
diff --git a/generated/go/porter/v1/cluster_control_plane.pb.go b/generated/go/porter/v1/cluster_control_plane.pb.go
diff --git a/generated/go/porter/v1/porterv1connect/cluster_control_plane.connect.go b/generated/go/porter/v1/porterv1connect/cluster_control_plane.connect.go
diff --git a/generated/go/porter/v1/system_service.pb.go b/generated/go/porter/v1/system_service.pb.go
diff --git a/generated/js/src/porter/v1/cluster_control_plane_pb.d.ts b/generated/js/src/porter/v1/cluster_control_plane_pb.d.ts
@@ -7147,11 +7147,11 @@ export declare class ListSystemServiceStatusRequest extends Message<ListSystemSe
  */
 export declare class ListSystemServiceStatusResponse extends Message<ListSystemServiceStatusResponse> {
   /**
-   * no_cluster_hearbeat is set to true if the cluster has not heartbeat in the last 10 minutes
+   * cluster_unresponsive is set to true if we haven't had contact with the cluster in the last 10 minutes
    *
-   * @generated from field: bool no_cluster_hearbeat = 1;
+   * @generated from field: bool cluster_unresponsive = 1;
    */
-  noClusterHearbeat: boolean;
+  clusterUnresponsive: boolean;
 
   /**
    * system_service_status is a list of system service statuses. Users can assume there is only one entry per a system service.

diff --git a/generated/js/src/porter/v1/cluster_control_plane_pb.js b/generated/js/src/porter/v1/cluster_control_plane_pb.js
@@ -2476,7 +2476,7 @@ export const ListSystemServiceStatusRequest = /*@__PURE__*/ proto3.makeMessageTy
 export const ListSystemServiceStatusResponse = /*@__PURE__*/ proto3.makeMessageType(
   "porter.v1.ListSystemServiceStatusResponse",
   () => [
-    { no: 1, name: "no_cluster_hearbeat", kind: "scalar", T: 8 /* ScalarType.BOOL */ },
+    { no: 1, name: "cluster_unresponsive", kind: "scalar", T: 8 /* ScalarType.BOOL */ },
     { no: 2, name: "system_service_status", kind: "message", T: SystemServiceStatus, repeated: true },
   ],
 );

diff --git a/generated/js/src/porter/v1/system_service_pb.d.ts b/generated/js/src/porter/v1/system_service_pb.d.ts
@@ -29,6 +29,7 @@ export declare enum ServiceStatus {
 
   /**
    * SERVICE_STATUS_PARTIAL_FAILURE is the health status for a partially failed service
+   * a service is in partial failure if only less than the max unavailable number of replicas declared on the service are failed
    *
    * @generated from enum value: SERVICE_STATUS_PARTIAL_FAILURE = 2;
    */

diff --git a/porter/v1/cluster_control_plane.proto b/porter/v1/cluster_control_plane.proto
@@ -1700,6 +1700,9 @@ service ClusterControlPlaneService {
 
   // NotificationConfig gets the notification config for a given id
   rpc NotificationConfig(NotificationConfigRequest) returns (NotificationConfigResponse) {}
+
+  // ListSystemServiceStatus fetches system service statuses for system services in a cluster
+  rpc ListSystemServiceStatus(ListSystemServiceStatusRequest) returns (ListSystemServiceStatusResponse) {}
 }
 
 message EKSBearerTokenRequest {
@@ -1928,8 +1931,8 @@ message ListSystemServiceStatusRequest {
 
 // ListSystemServiceStatusResponse is the response object for listing system service status
 message ListSystemServiceStatusResponse {
-  // no_cluster_hearbeat is set to true if the cluster has not heartbeat in the last 10 minutes
-  bool no_cluster_hearbeat = 1;
+  // cluster_unresponsive is set to true if we haven't had contact with the cluster in the last 10 minutes
+  bool cluster_unresponsive = 1;
   // system_service_status is a list of system service statuses. Users can assume there is only one entry per a system service.
   repeated SystemServiceStatus system_service_status = 2;
 }
diff --git a/porter/v1/system_service.proto b/porter/v1/system_service.proto
@@ -21,6 +21,7 @@ enum ServiceStatus {
   // SERVICE_STATUS_HEALTHY is the value for a fully healthy service
   SERVICE_STATUS_HEALTHY = 1;
   // SERVICE_STATUS_PARTIAL_FAILURE is the health status for a partially failed service
+  // a service is in partial failure if only less than the max unavailable number of replicas declared on the service are failed
   SERVICE_STATUS_PARTIAL_FAILURE = 2;
   // SERVICE_STATUS_FAILURE is the health status for a fully failed service
   SERVICE_STATUS_FAILURE = 3;
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,7 @@ export declare enum ServiceStatus { @@
       /**
        * SERVICE_STATUS_PARTIAL_FAILURE is the health status for a partially failed service
+       * a service is in partial failure if only less than the max unavailable number of replicas declared on the service are failed
        *
        * @generated from enum value: SERVICE_STATUS_PARTIAL_FAILURE = 2;
        */
@@ Expand Down @@