Change Aggregation Property resource to Aggregation Properties resource #99
Conversation
Tankilevitch
changed the title
Tankilevitch
changed the title
| return | ||
| } | ||
|
|
||
| //blueprintIdentifier := state.BlueprintIdentifier.ValueString() |
internal/cli/blueprint.go
Outdated
| @@ -66,6 +66,27 @@ func (c *PortClient) UpdateBlueprint(ctx context.Context, b *Blueprint, id strin | |||
| return &pb.Blueprint, nil | |||
| } | |||
|
|
|||
| func (c *PortClient) PatchBlueprint(ctx context.Context, b *Blueprint, id string) (*Blueprint, error) { | |||
There was a problem hiding this comment.
It's not being used (?)
| return | ||
| } | ||
|
|
||
| err = refreshAggregationPropertyState(state, bp.AggregationProperties) |
| return | ||
| } | ||
|
|
||
| err = refreshAggregationPropertyState(state, bp.AggregationProperties) |
| for aggregationPropertyIdentifier, aggregationProperty := range aggregationProperties { | ||
|
|
||
| state.Properties[aggregationPropertyIdentifier] = &AggregationPropertyModel{ | ||
| types.StringPointerValue(aggregationProperty.Title), |
There was a problem hiding this comment.
I prefer to specify the struct keys explicitly
| } | ||
|
|
||
| if aggregationProperty.Query != nil { | ||
| query, err := json.Marshal(aggregationProperty.Query) |
There was a problem hiding this comment.
I think you can use GoObjectToTerraformString util
| "func": "count", | ||
| "calculationBy": "entities", | ||
| } | ||
| } else if aggregationProperty.Method.AverageEntities != nil { |
There was a problem hiding this comment.
The elses are redundant no? Can be just serial ifs
| MarkdownDescription: "Function to count the entities of the target entities", | ||
| Optional: true, | ||
| Validators: []validator.Bool{ | ||
| boolvalidator.ConflictsWith(path.MatchRelative().AtParent().AtName("average_entities")), |
There was a problem hiding this comment.
I think you want ExactlyOneOf and not ConflictsWith, because otherwise you also support an empty method. And also using ExactlyOneOf you can specify the validators once (maybe right also with ConflictsWith)
| icon = "Terraform" | ||
| identifier = "%s" | ||
| description = "" | ||
| relations = { |
There was a problem hiding this comment.
Something seems not right with the identation of relations throughout the file, it seems like because here the indentation is with spaces, and other places with tabs
| parentBlueprintIdentifier := utils.GenID() | ||
| childBlueprintIdentifier := utils.GenID() | ||
| var testAccActionConfigCreate = fmt.Sprintf(` | ||
| resource "port_blueprint" "parent_blueprint" { |
There was a problem hiding this comment.
Maybe you can extract the parent and child blueprint definition and reuse, it will be more difficult to maintain it in the future like this
Description
What -
Why -
How -
Type of change
Please leave one option from the following and delete the rest: