Change to new action #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
approved these changes
Jan 16, 2024
Comment on lines
+50
to
+52
| if blueprintIdentifier != "" { | ||
| actionIdentifier = fmt.Sprintf("%s_%s", blueprintIdentifier, actionIdentifier) | ||
| } |
There was a problem hiding this comment.
I would add a comment stating why we do it, and when this would happen ( iiuc when first loading the previous state and moving to the new state )
port/action/actionStateToPortBody.go
Outdated
Comment on lines
45
to
47
| if !data.Title.IsNull() { | ||
| title := data.Title.ValueString() | ||
| action.Title = &title |
There was a problem hiding this comment.
Suggested change
| if !data.Title.IsNull() { | |
| title := data.Title.ValueString() | |
| action.Title = &title | |
| action.Title = data.Title.ValueStringPointer() |
There was a problem hiding this comment.
this can be adjusted for Icon & description as well
port/action/actionStateToPortBody.go
Outdated
Comment on lines
92
to
95
| if !data.Publish.IsNull() { | ||
| publish := data.Publish.ValueBool() | ||
| action.Publish = &publish | ||
| } |
There was a problem hiding this comment.
same here ValueBoolPointer()
Comment on lines
+92
to
+102
| func StringBooleanOrJQTemplateValidator() []validator.String { | ||
| return []validator.String{ | ||
| stringvalidator.Any( | ||
| stringvalidator.OneOf("true", "false"), | ||
| stringvalidator.RegexMatches( | ||
| regexp.MustCompile(`^[\n\r\s]*{{.*}}[\n\r\s]*$`), | ||
| "must be a valid jq template: {{JQ_EXPRESSION}}", | ||
| )), | ||
| } | ||
| } | ||
|
|
…w-actions-api-and-routes
talsabagport
deleted the
PORT-5367-update-iac-providers-to-support-new-actions-api-and-routes
branch
erikzaadi
added a commit
that referenced
this pull request
May 9, 2024
…roviders-to-support-new-actions-api-and-routes" This reverts commit c316a55.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Change to new action
Type of change
Please leave one option from the following and delete the rest: