Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] | Enforce independent resource provisioning per environment #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mk-armah
Copy link
Member

@mk-armah mk-armah commented Oct 21, 2024

Issue:
When executing terraform apply with project feeds that already exist within the GCP account, Terraform fails and returns an error stating that the feed already exists.

Solution:
To prevent such errors and enhance support for multi deployments, We Introduce an extra variable environment that prefixes the resources identifiers, enforcing unique identifier per deployment and preventing the duplication error.

Changes Include:

  • Enhanced support for multi deployment setups by adding an extra variable environment. (e.g stg, prod)`
  • Updated default naming convention to utilize the given integration_name and environment.
    e.g my-gcp-integration-prod, my-gcp-integration-stg,my-gcp-integration-dev

Benefits:

  • Prevents Terraform from failing due to duplicate feed errors.
  • Allows for smoother integration with pre-existing GCP asset feeds.
  • Easy identification of integration resources due to the consistent naming convention between Port and GCP integration

Testing:
Verified that terraform apply successfully skips the creation of existing feeds and applies changes without errors.

@mk-armah mk-armah changed the title Enforce independent resource provisioning per environment [GCP] | Enforce independent resource provisioning per environment Oct 21, 2024
@mk-armah mk-armah requested review from Tankilevitch and matan84 and removed request for Tankilevitch October 21, 2024 13:03
@mk-armah mk-armah closed this Oct 23, 2024
@mk-armah mk-armah reopened this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant