upgrade libssl3 libcrypto3 to solve CVE-2024-9143 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzaadi
force-pushed
the
fix-issue-84
branch
from
bbfd068 to
0478980
Compare
Updates #84 and PORT-11090
erikzaadi
force-pushed
the
fix-issue-84
branch
from
0478980 to
029b87a
Compare
erikzaadi
force-pushed
the
fix-issue-84
branch
2 times, most recently
from
adcd2f2 to
171c3ee
Compare
erikzaadi
force-pushed
the
fix-issue-84
branch
2 times, most recently
from
47d05ec to
0cee1ce
Compare
erikzaadi
force-pushed
the
fix-issue-84
branch
from
0cee1ce to
3b2d958
Compare
| pb := &port.ResponseBody{} | ||
| resp, err := portClient.Client.R(). | ||
| SetResult(&pb). | ||
| Delete(fmt.Sprintf("v1/blueprints/%s/all-entities?delete_blueprint=false", blueprintIdentifier)) |
There was a problem hiding this comment.
In our case we want to delete the blueprint, so it might be more efficient to do it in one call
| } | ||
|
|
||
| if !pb.OK { | ||
| return fmt.Errorf("failed to delete blueprint, got: %s", resp.Body()) |
There was a problem hiding this comment.
delete blueprint entities?
| @@ -48,15 +56,19 @@ func (f *Fixture) CleanIntegration() { | |||
|
|
|||
| func deleteDefaultResources(portClient *cli.PortClient, stateKey string) { | |||
| _ = integration.DeleteIntegration(portClient, stateKey) | |||
| _ = blueprint.DeleteBlueprintEntities(portClient, "workload") | |||
There was a problem hiding this comment.
Consider having one function for DeleteBlueprint, with just a flag to delete all entities
| @@ -275,5 +294,7 @@ func Test_InitIntegration_LocalResourcesConfiguration_ExistingIntegration_WithCo | |||
| assert.Nil(t, err) | |||
| assert.Equal(t, expectedConfig.Resources, i.Config.Resources) | |||
|
|
|||
| testUtils.CheckResourcesExistence(false, f.portClient, f.t, []string{"workload", "namespace", "cluster"}, []string{"workload_overview_dashboard", "availability_scorecard_dashboard"}, []string{}) | |||
| testUtils.CheckResourcesExistence(false, false, f.portClient, f.t, []string{"workload", "namespace", "cluster"}, []string{"workload_overview_dashboard", "availability_scorecard_dashboard"}, []string{}) | |||
| defer tearDownFixture(t, f) | |||
There was a problem hiding this comment.
Don't you want to defer teardown fixture near its creation, like in other tests?
| @@ -63,7 +80,7 @@ func TestPolling_DifferentConfiguration(t *testing.T) { | |||
| }) | |||
|
|
|||
| c <- time.Now() | |||
| time.Sleep(time.Millisecond * 500) | |||
| time.Sleep(time.Millisecond * 1500) | |||
There was a problem hiding this comment.
Any reason why it takes 3 times longer now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #84
Description
Update dockerfiles to solve CVE-2024-9143
Type of change