Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Metric and SLO History to DD Integration #1331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ToddRizley
Copy link

@ToddRizley ToddRizley commented Jan 16, 2025

Description

What -
This PR adds out of the box resource blueprints and mappings for SLO History and Service Metric entities. Note this will only work for Ocean, not for the Port hosted integration. I recommend the engineering team consider making this default for that integration setup as well.

Why -
Currently, the documentation lists both Service Metric and SLO History as supported resources. There isn't, however, any indication that these require additional configuration via a blueprint and resource mapping.

How -
blueprints.json and port-app-config.yaml are updated for the Datadog integration for Ocean.

Type of change

Please leave one option from the following and delete the rest:

  • [ X] Bug fix (non-breaking change which fixes an issue)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@ToddRizley ToddRizley requested a review from a team as a code owner January 16, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant