[Core] reduce port system load

[yaelibarg]

Description

What - reduce the amount of upserts we send to port api

Why - many of the upserts does not contain an actual change, reduce load from port api

How - check if the entity from the third party has a change from the entity in port, and only if there is an actual change, upsert the entity

Type of change

Please leave one option from the following and delete the rest:

• Bug fix (non-breaking change which fixes an issue)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

• Integration able to create all default resources from scratch
• Resync finishes successfully
• Resync able to create entities
• Resync able to update entities
• Resync able to detect and delete entities
• Scheduled resync able to abort existing resync and start a new one
• Tested with at least 2 integrations from scratch
• Tested with Kafka and Polling event listeners
• Tested deletion of entities that don't pass the selector

[Tankilevitch]

I think the first layer is redundant as eventually we are constructing a query for finding the entity identifiers therefor only the or part is of interest for us.

Suggested change

	return {
	"combinator": "and",
	"rules": [
	{
	"combinator": "or",
	"rules": [
	{
	"property": "$identifier",
	"operator": "=",
	"value": entity.identifier,
	}
	for entity in entities
	]
	}
	]
	}
	return
	{
	"combinator": "or",
	"rules": [
	{
	"property": "$identifier",
	"operator": "=",
	"value": entity.identifier,
	}
	for entity in entities
	]
	}

[yaelibarg]

we add on this query after , in the search_entities function, so you have that the first layer will be 'and' layer