Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][AWS] | Fix an issue where the integration enters an endless loop on region permission error #1169

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

mk-armah
Copy link
Member

@mk-armah mk-armah commented Nov 21, 2024

Description

What:

Fixed an issue where the integration would enter an endless loop upon encountering a permission error when querying resources in a particular region. The code now raises the permission error instead of skipping it, allowing downstream code to handle it appropriately.

Why:

Previously, when a permission error occurred, the integration skipped the error without proper handling, causing it to get stuck in an infinite loop. By raising the error, we ensure that the integration does not loop endlessly and that the error can be managed correctly by downstream processes.

How:

  • Updated the error handling logic to raise the permission error instead of skipping it.
  • Verified that downstream code is capable of handling the raised exception without adverse effects.
  • Tested the integration to confirm that it no longer enters an endless loop on permission errors.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

…on error when querying resources in a region without permission
@mk-armah mk-armah requested a review from a team as a code owner November 21, 2024 13:38
@mk-armah mk-armah changed the title Fix an issue where the integration enters an endless loop on permissi… [Integration][AWS] | Fix an issue where the integration enters an endless loop on permissi… Nov 21, 2024
@mk-armah mk-armah changed the title [Integration][AWS] | Fix an issue where the integration enters an endless loop on permissi… [Integration][AWS] | Fix an issue where the integration enters an endless loop on region permission error Nov 21, 2024
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines 264 to 265

raise e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the warning log since it's kind of confusing

Suggested change
raise e
except Exception as e:
logger.error(
f"Error resyncing {kind} in region {region} in account {account_id}, {e}"
)
raise e

Copy link
Contributor

@shalev007 shalev007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's push it after you remove the log

@shalev007 shalev007 merged commit 7d6cbb4 into main Nov 21, 2024
18 checks passed
@shalev007 shalev007 deleted the aws/port-11555 branch November 21, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants