-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][AWS] | Fix an issue where the integration enters an endless loop on region permission error #1169
Conversation
…on error when querying resources in a region without permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
integrations/aws/utils/resources.py
Outdated
|
||
raise e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also remove the warning log since it's kind of confusing
raise e | |
except Exception as e: | |
logger.error( | |
f"Error resyncing {kind} in region {region} in account {account_id}, {e}" | |
) | |
raise e | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's push it after you remove the log
Description
What:
Fixed an issue where the integration would enter an endless loop upon encountering a permission error when querying resources in a particular region. The code now raises the permission error instead of skipping it, allowing downstream code to handle it appropriately.
Why:
Previously, when a permission error occurred, the integration skipped the error without proper handling, causing it to get stuck in an infinite loop. By raising the error, we ensure that the integration does not loop endlessly and that the error can be managed correctly by downstream processes.
How:
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.