Skip to content

Commit

Permalink
feat: Add useGetResource property to AWS default mapping (#724)
Browse files Browse the repository at this point in the history
# Description

What - use unique identifier in AWS default mapping
Why - some of the resources can be overriden if they are created in the
same name in a different region/account
How - use `ARN` property or globally unique identifier

## Type of change

Please leave one option from the following and delete the rest:

- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.

---------

Co-authored-by: Shalev Avhar <[email protected]>
  • Loading branch information
shalev007 and Shalev Avhar authored Jun 19, 2024
1 parent eede53d commit f1ed5c0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 3 additions & 1 deletion integrations/aws/.port/resources/port-app-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ resources:
- kind: AWS::S3::Bucket
selector:
query: 'true'
useGetResource: 'true'
port:
entity:
mappings:
Expand Down Expand Up @@ -52,10 +53,11 @@ resources:
- kind: AWS::ECS::Cluster
selector:
query: 'true'
useGetResource: 'true'
port:
entity:
mappings:
identifier: .Identifier
identifier: .Properties.Arn
title: .Identifier
blueprint: '"cloudResource"'
properties:
Expand Down
6 changes: 6 additions & 0 deletions integrations/aws/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- towncrier release notes start -->

# Port_Ocean 0.2.5 (2024-06-17)

### Improvements

- Changed default mapping to include describeResources for resources which doesn't include tags by default from cloud control (#1)

# Port_Ocean 0.2.4 (2024-06-17)

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion integrations/aws/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "aws"
version = "0.2.4"
version = "0.2.5"
description = "This integration will map all your resources in all the available accounts to your Port entities"
authors = ["Shalev Avhar <[email protected]>"]

Expand Down

0 comments on commit f1ed5c0

Please sign in to comment.