Skip to content

Commit

Permalink
[Integration][Datadog] Fixed mapping issues (#1292)
Browse files Browse the repository at this point in the history
# Description

What - Fixed mapping issue with OAuth

Why - Failed to create integrations based on provided strings

How - Changed strings

## Type of change

Please leave one option from the following and delete the rest:

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

<h4> All tests should be run against the port production
environment(using a testing org). </h4>

### Core testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync finishes successfully
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Scheduled resync able to abort existing resync and start a new one
- [ ] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector


### Integration testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add
example raw data, mapping and expected result to the `examples` folder
in the integration directory.
- [ ] If resource kind is updated, run the integration with the example
data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that
live-events for that resource are working as expected
- [ ] Docs PR link [here](#)

### Preflight checklist

- [ ] Handled rate limiting
- [ ] Handled pagination
- [ ] Implemented the code in async
- [ ] Support Multi account

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.
  • Loading branch information
matan84 authored Jan 2, 2025
1 parent 7c94f85 commit 70063e2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
4 changes: 2 additions & 2 deletions integrations/datadog/.port/spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ saas:
oauthConfiguration:
requiredSecrets:
- name: datadogApiKey
value: '\"OAUTH_ENABLED_API_KEY\"'
value: '"OAUTH_ENABLED_API_KEY"'
description: '"API Key for Datadog OAuth2 integration- Not used when OAuth is enabled"'
- name: datadogApplicationKey
value: '\"OAUTH_ENABLED_APPLICATION_KEY\"'
value: '"OAUTH_ENABLED_APPLICATION_KEY"'
description: '"Application Key for Datadog OAuth2 integration- Not used when OAuth is enabled"'
- name: datadogAccessToken
value: '.oauthData.accessToken'
Expand Down
7 changes: 7 additions & 0 deletions integrations/datadog/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

<!-- towncrier release notes start -->
## 0.2.2 (2025-01-02)


### Bugfixes

- Fixed the OAuth2 integration mapping for plain text values


## 0.2.1 (2025-01-02)

Expand Down
2 changes: 1 addition & 1 deletion integrations/datadog/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "datadog"
version = "0.2.1"
version = "0.2.2"
description = "Datadog Ocean Integration"
authors = ["Albert Luganga <[email protected]>"]

Expand Down

0 comments on commit 70063e2

Please sign in to comment.