Skip to content

Commit

Permalink
Added entities deletion by selector test case to pr core checklist (#964
Browse files Browse the repository at this point in the history
)
  • Loading branch information
omby8888 authored Aug 29, 2024
1 parent d94f0ed commit 5d7eda9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Please leave one option from the following and delete the rest:
- [ ] Scheduled resync able to abort existing resync and start a new one
- [ ] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector


### Integration testing checklist
Expand All @@ -38,7 +39,7 @@ Please leave one option from the following and delete the rest:
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory.
- [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory.
- [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected
- [ ] Docs PR link [here](#)
Expand Down

0 comments on commit 5d7eda9

Please sign in to comment.