Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimized if-statement in configmap.yaml #20

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix: optimized if-statement in configmap.yaml #20

merged 2 commits into from
Jul 24, 2024

Conversation

Kerwood
Copy link
Contributor

@Kerwood Kerwood commented Jul 10, 2023

Turned this:

{{- if $config_lookup -}}
  {{- if $config_lookup.data -}}
    {{- if $config_lookup.data.state_key -}}
      {{- $config = $config_lookup.data.state_key -}}

Into this:

  {{- if (($config_lookup).data).state_key -}}
  {{- $config = $config_lookup.data.state_key -}}

Copy link
Contributor

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 Looking good

Refactored if-statement christmas tree.
@Kerwood
Copy link
Contributor Author

Kerwood commented Jul 23, 2024

Rebased and fixed conflicts.

@yairsimantov20
Copy link
Contributor

Can you please also bump the version in the chart.yaml
It is still managed manually

@Kerwood
Copy link
Contributor Author

Kerwood commented Jul 24, 2024

Done

@MPTG94 MPTG94 merged commit ad68fcb into port-labs:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants